[material-ui][BottomNavigationAction] Add slots and slotProps #45776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45776--material-ui.netlify.app/ BottomNavigationAction: parsed: +2.35% , gzip: +2.16% Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
added
component: bottom navigation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for slots and slotProps for the BottomNavigationAction component, allowing customization of its internal structure. Key changes include:
- Introducing a CustomButtonBase for testing slot behavior.
- Updating BottomNavigationAction to use the useSlot utility for managing root and label slots.
- Extending prop types to include new slots and slotProps definitions.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/mui-material/src/BottomNavigationAction/BottomNavigationAction.test.js | Adds a custom button for slot testing and passes custom slots to the conformance tests. |
| packages/mui-material/src/BottomNavigationAction/BottomNavigationAction.js | Integrates the useSlot utility to support slot-based customization and adds corresponding prop types. |
Files not reviewed (2)
- docs/pages/material-ui/api/bottom-navigation-action.json: Language not supported
- docs/translations/api-docs/bottom-navigation-action/bottom-navigation-action.json: Language not supported
Comments suppressed due to low confidence (1)
packages/mui-material/src/BottomNavigationAction/BottomNavigationAction.test.js:27
- [nitpick] Consider adding tests that explicitly validate the behavior of slotProps for both root and label slots to ensure the expected props are forwarded correctly.
slots: {
siriwatknp
reviewed
Apr 9, 2025
| }; | ||
|
|
||
| const [RootSlot, rootProps] = useSlot('root', { | ||
| elementType: BottomNavigationActionRoot, |
There was a problem hiding this comment.
Suggested change
| elementType: BottomNavigationActionRoot, | |
| shouldForwardComponentProp: true, | |
| elementType: BottomNavigationActionRoot, |
The BottomNavigationActionRoot comes from a ButtonBase.
siriwatknp
approved these changes
Apr 11, 2025
sai6855
added
v6.x
needs cherry-pick
|
Cherry-pick PRs will be created targeting branches: v6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.