[docs][Menu] Update paper slot JSDoc default from Paper to PopoverPaper
#45722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PopoverPaper is the real instance. In fact, if you try to just apply a new Paper instance to the slot, the UI is broken in terms of paper positioning. Signed-off-by: Andrea Chiera <[email protected]>
Netlify deploy previewhttps://deploy-preview-45722--material-ui.netlify.app/ Bundle size report |
|
Since there are issues in compiling the documentation, I could add this information inside the Description column? |
andreachiera
changed the title
mnajdova
previously requested changes
Mar 28, 2025
There was a problem hiding this comment.
This json files are automatically generated out of the types, we will need to change this: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Menu/Menu.d.ts#L32 instead and run
pnpm proptypes
pnpm docs:api
mnajdova
added
docs
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
v6.x
needs cherry-pick
ZeeshanTamboli
changed the title
paper slot JSDoc default from Paper to PopoverPaper
ZeeshanTamboli
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
@andreachiera Thanks for the pull request. I made the expected changes.
|
Cherry-pick PRs will be created targeting branches: v6.x |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
…erPaper` (#45722) Signed-off-by: Andrea Chiera <[email protected]> Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PopoverPaper is the real instance used inside the component. If you try to just apply a new Paper instance to the slot, the UI is broken in terms of positioning.