[material-ui][Fab] Fix default variant text color when using CSS vars #45714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
component: Fab
aarongarciah
changed the title
Netlify deploy previewhttps://deploy-preview-45714--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
aarongarciah
force-pushed
the
fix-fab-color
branch
from
70c1bb2 to
6c7245c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect text color for Fabs when CSS variables are used by replacing the color reference from theme.vars.palette.text.primary to theme.vars.palette.grey[900].
- Update color computation in Fab to address contrast issues with the default variant.
- Aligns the color definition with the intended design for CSS variable usage.
Comments suppressed due to low confidence (1)
packages/mui-material/src/Fab/Fab.js:69
- [nitpick] Consider adding a comment explaining the rationale for using palette.grey[900] instead of palette.text.primary, referencing issue [Fab] Wrong colors in dark mode for default variant #45712 for future maintainability.
theme.vars.palette.grey[900]
DiegoAndai
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45712