-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[core] Prepare v6 branch for v7 stable release #45668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments, in general it looks good, let's resolve the comments before merging.
/x/* https://material-ui-x.netlify.app/x/:splat 200 | ||
/r/x-* https://material-ui-x.netlify.app/r/x-:splat 200 | ||
/:lang/x/* https://material-ui-x.netlify.app/:lang/x/:splat 200 | ||
/static/x/* https://docs-v6--material-ui-x.netlify.app/static/x/:splat 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link seems wrong. Currently mui.com points to v7 of the DataGrid, not v6, while https://docs-v6--material-ui-x.netlify.app/x/introduction/ points to the v6 of the DataGrid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct. These redirects are for DataGrid users who want to see v6 docs.
Ex, access to https://v6.mui.com/x/react-data-grid/*
, request assets to `https://v6.mui.com/static/x/* should redirect to docs v6 assets of X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing something but Material UI v6 docs <-> MUI X v7 docs, e.g. on current mui.com the associated MUI X version is v7. Shouldn't we keep this parity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexfauquette asked me to keep these as they are in the docs' v6
branch: mui/material-ui-docs@e963c3d
I guess the options are:
- v6.mui.com pointing to v6 X docs, which is consistent but breaks Material UI v6 docs <-> MUI X v7 docs
- v6.mui.com redirecting to v7 X, which might be unexpected for users but keeps Material UI v6 docs <-> MUI X v7 docs
None are great options, but it's what we have given our docs and domain structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, if the X team is on board with this, we can close the discussion 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't do that, the v6.mui.com/x/
will display the docs of the v7 and the v6 will be impossible to reach
/x/_next/* https://docs-v6--material-ui-x.netlify.app/_next/:splat 200 | ||
/x/* https://docs-v6--material-ui-x.netlify.app/x/:splat 200 | ||
/r/x-* https://docs-v6--material-ui-x.netlify.app/r/x-:splat 200 | ||
/:lang/x/* https://docs-v6--material-ui-x.netlify.app/:lang/x/:splat 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the previous question, what's the right docs we should redirect to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same answer I commented above.
Prepare
v6.x
branch for Material UI's v7 stable release:#*-reference
tags that were using the legacy#default-branch-switch
, and remove some that weren't needed.