Skip to content

[material-ui][Snackbar] Skip default behaviour when defaultMuiPrevent… #45629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 15, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 20, 2025

closes #45610

@sai6855 sai6855 changed the title Snackbar-close [material-ui][SnackBar] Skip default behaviour when defaultMuiPrevent… Mar 20, 2025
@sai6855 sai6855 marked this pull request as draft March 20, 2025 05:37
@mui-bot
Copy link

mui-bot commented Mar 20, 2025

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 19e76e5

@sai6855 sai6855 added bug 🐛 Something doesn't work component: snackbar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Mar 20, 2025
@sai6855 sai6855 requested a review from siriwatknp March 24, 2025 06:01
@@ -65,6 +65,23 @@ You can use the `TransitionComponent` prop to change the transition of the Snack

{{"demo": "TransitionsSnackbar.js"}}

## Events
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sai6855 sai6855 marked this pull request as ready for review March 24, 2025 06:02
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][SnackBar] Skip default behaviour when defaultMuiPrevent… [material-ui][Snackbar] Skip default behaviour when defaultMuiPrevent… Mar 27, 2025
@@ -65,6 +65,23 @@ You can use the `TransitionComponent` prop to change the transition of the Snack

{{"demo": "TransitionsSnackbar.js"}}

## Events
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved under Customization with title "Preventing default click away event".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the docs.

@sai6855 sai6855 requested a review from siriwatknp April 9, 2025 10:54
@siriwatknp siriwatknp merged commit 4d6428e into mui:master Apr 15, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: snackbar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Snackbar] ClickAwayListener SlotProps are ignored when provided
3 participants