Skip to content

[utils] Support cleanup callbacks in useForkRef #45621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Mar 19, 2025

@DiegoAndai DiegoAndai added package: utils Specific to the @mui/utils package React 19 support About improving React 19 support labels Mar 19, 2025
@DiegoAndai DiegoAndai self-assigned this Mar 19, 2025
@mui-bot
Copy link

mui-bot commented Mar 19, 2025

Netlify deploy preview

https://deploy-preview-45621--material-ui.netlify.app/

Portal: parsed: +26.42% , gzip: +16.72%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c628288

@DiegoAndai DiegoAndai requested a review from aarongarciah March 19, 2025 17:38
@DiegoAndai DiegoAndai marked this pull request as ready for review March 19, 2025 17:38
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a test?

@DiegoAndai
Copy link
Member Author

@aarongarciah done! Also taken from mui/base-ui#1553

@DiegoAndai DiegoAndai added v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Mar 20, 2025
@DiegoAndai DiegoAndai merged commit cd5759f into mui:master Mar 28, 2025
21 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge package: utils Specific to the @mui/utils package React 19 support About improving React 19 support v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 19 Ref callback cleanup functions are not invoked on MUI components
3 participants