[code-infra] Migrate regression tests to vite #44964
Conversation
Netlify deploy previewhttps://deploy-preview-44964--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
|
Recently swapped out webpack for vite in the e2e/regressions setup here too 😬 |
github-actions
bot
removed
the
PR: out-of-date
Janpot
changed the title
github-actions
bot
added
the
PR: out-of-date
test/regressions/index.js
Outdated
| const importDemos = import.meta.glob( | ||
| [ | ||
| 'docs/data/**/[A-Z]*.js', | ||
| 'docs/data/base/**/[A-Z]*/css/index.js', | ||
| 'docs/data/base/**/[A-Z]*/tailwind/index.js', | ||
| 'docs/data/base/**/[A-Z]*/system/index.js', |
There was a problem hiding this comment.
It would be nice to comment mentioning this is a include globs followed by exclude globs 😅
There was a problem hiding this comment.
Great point, since now those are combined. 💡
There was a problem hiding this comment.
👍 did another pass over this patterns list and cleaned it up, sorted alphabetically and added a comment deliniating the inclusions from the exclusions
test/regressions/index.js
Outdated
| const importDemos = import.meta.glob( | ||
| [ | ||
| 'docs/data/**/[A-Z]*.js', | ||
| 'docs/data/base/**/[A-Z]*/css/index.js', | ||
| 'docs/data/base/**/[A-Z]*/tailwind/index.js', | ||
| 'docs/data/base/**/[A-Z]*/system/index.js', |
There was a problem hiding this comment.
Great point, since now those are combined. 💡
| export default defineConfig({ | ||
| plugins: [ | ||
| { | ||
| // Unfortunatelly necessary as we opted to write our jsx in js files |
There was a problem hiding this comment.
It's on my to do list. This has been causing trouble every time we try to introduce a tool that relies on esbuild.
I may be checking this wrong, but the only thing I see bringing in vite 5 is |
github-actions
bot
removed
the
PR: out-of-date
Avoid
React.lazy, I don't feel like it brings a lot of benefit here as we're running through all the fixtures anyway and it causes throttled fallbacks in the suspense boundary.If the blacklist is too big, this may cause a lot of overhead in the bundle. Alternative would be to generate a virtual module that re-exports all desired fixtures and no more.just migrate regression tests to vite so we can encode the blacklist in the glob and avoid them in the bundle altogether
blocked on #44976
screenshot generation seems to run about ~30s (~15%) faster now
1 failing screenshot in joy theme viewer, caused by vitejs/vite#13727. We can ignore this for now