-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[useMediaQuery] Add warning and docs for using useMediaQuery('print')
#44790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[useMediaQuery] Add warning and docs for using useMediaQuery('print')
#44790
Conversation
- Explained that 'print' queries may not accurately reflect re-rendering changes in print environments.
- Added warning for using `print` query
Netlify deploy preview@material-ui/core/useMediaQuery: parsed: +2.95% , gzip: +4.16% Bundle size reportDetails of bundle changes (Toolpad) |
useMediaQuery('print')
useMediaQuery('print')
useMediaQuery('print')
useMediaQuery('print')
docs/data/material/components/use-media-query/use-media-query.md
Outdated
Show resolved
Hide resolved
docs/data/material/components/use-media-query/use-media-query.md
Outdated
Show resolved
Hide resolved
13649ee
to
c1fbb29
Compare
useMediaQuery('print')
useMediaQuery('print')
useMediaQuery('print')
useMediaQuery('print')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@good-jinu Thanks for the PR.
Cherry-pick PRs will be created targeting branches: v6.x |
…)` (#44790) Co-authored-by: ZeeshanTamboli <[email protected]>
Closes #17595
If these 'print' query warnings are deemed unnecessary, they will be removed.
Review them please.