-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[material-next][ButtonGroup] Add ButtonGroup component with Material You design #39699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy preview@mui/material-next: parsed: +1.39% , gzip: +0.95% Bundle size reportDetails of bundle changes (Toolpad) |
@lhilgert9 I would suggest you separate the first 3 commits here into a separate PR that we can merge first, so that the diffs in this one (with the actual code changes) are not all green and easier to review 🙏 Example: #39635 |
@mj12albert I split the PR as you suggested. The copying of the files, as well as fixing the import errors are now in PR #39716. |
@mj12albert @DiegoAndai I have fixed the most issues, but there are still two tests not working.
if (/jsdom/.test(window.navigator.userAgent)) {
this.skip();
} for the test that fails. Alternatively, we could implement something like mentioned here: https://jestjs.io/docs/manual-mocks#mocking-methods-which-are-not-implemented-in-jsdom. What are your thougts on this? Since all other errors have been corrected, I would suggest continuing to work in this PR and closing the PR #39716. |
Don't worry about the argos one for now, sometimes it's quite flaky! |
import ButtonGroupContext from './ButtonGroupContext'; | ||
import { CssVarsProvider, extendTheme } from '../styles'; | ||
|
||
describe('<ButtonGroup />', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mj12albert Okay that helped. I have fixed all the error and I think now its done. |
@lhilgert9 That works too ~ it may be easier to ensure that the changes from #38520 are incorporated from the beginning! |
@mj12albert the changes in #38520 are included in both #39716 and this one. I just thought it would be easier to create new PRs now, because I now know what changes I have to make one after the other so that no errors occur in the individual PRs. |
@mj12albert @DiegoAndai
Let me know if you have any other suggestions. Otherwise, please give me the go ahead to close #39716 and start with these PRs I suggested. |
@lhilgert9 that sounds good 🙌🏼 go ahead and close #39716 |
Close this PR in favor of
|
ButtonGroup issue: #39686
Material You umbrella issue: #29345
Changes
Preview: https://deploy-preview-39699--material-ui.netlify.app/material-ui/react-button-group/#material-you-version
Add Slider component implementing Material You style specifications:
material
v5Known Issues
variant
is set to "filledTonal" or "elevated" the color is changing to "primary", but this is a bug in the Button component