Skip to content

[base-ui][NumberInput] Implement numberInputReducer #38723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/pages/base-ui/api/number-input.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
},
"startAdornment": { "type": { "name": "node" } },
"step": { "type": { "name": "number" } },
"value": { "type": { "name": "any" } }
"value": { "type": { "name": "number" } }
},
"name": "NumberInput",
"imports": [
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/base-ui/api/use-number-input.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"required": { "type": { "name": "boolean", "description": "boolean" } },
"shiftMultiplier": { "type": { "name": "number", "description": "number" } },
"step": { "type": { "name": "number", "description": "number" } },
"value": { "type": { "name": "unknown", "description": "unknown" } }
"value": { "type": { "name": "number", "description": "number" } }
},
"returnValue": {
"disabled": {
Expand Down
2 changes: 1 addition & 1 deletion packages/mui-base/src/Unstable_NumberInput/NumberInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ NumberInput.propTypes /* remove-proptypes */ = {
/**
* The current value. Use when the component is controlled.
*/
value: PropTypes.any,
value: PropTypes.number,
} as any;

export { NumberInput };
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
export const NumberInputActionTypes = {
clamp: 'numberInput:clamp',
inputChange: 'numberInput:inputChange',
increment: 'numberInput:increment',
decrement: 'numberInput:decrement',
decrementToMin: 'numberInput:decrementToMin',
incrementToMax: 'numberInput:incrementToMax',
} as const;

interface NumberInputClampAction {
type: typeof NumberInputActionTypes.clamp;
inputValue: string;
}

interface NumberInputInputChangeAction {
type: typeof NumberInputActionTypes.inputChange;
inputValue: string;
}

interface NumberInputIncrementAction {
type: typeof NumberInputActionTypes.increment;
applyMultiplier: boolean;
}

interface NumberInputDecrementAction {
type: typeof NumberInputActionTypes.decrement;
applyMultiplier: boolean;
}

interface NumberInputIncrementToMaxAction {
type: typeof NumberInputActionTypes.incrementToMax;
}

interface NumberInputDecrementToMinAction {
type: typeof NumberInputActionTypes.decrementToMin;
}

export type NumberInputAction =
| NumberInputClampAction
| NumberInputInputChangeAction
| NumberInputIncrementAction
| NumberInputDecrementAction
| NumberInputIncrementToMaxAction
| NumberInputDecrementToMinAction;
Loading