Skip to content

Manage pools better #8129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2025
Merged

Manage pools better #8129

merged 2 commits into from
May 4, 2025

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Apr 28, 2025

I made it so pools track gameids instead of just being a counter, and then we periodically (every 30 minutes) check them against the actual lobbies and fix any stale entries.

I did this because I noticed on the server log that the number of assigned pools seems to gradually climb higher than the number of lobbies, and I think it's one of:

  • some lobbies crashing and not getting unregistered
  • some lobbies colliding on creation and the side-effects of that being redone, so sometimes they get added twice (I think this is how atoms work?)

Anyway if that's true or not, this should handle both of those.

@NBKelly NBKelly merged commit 49b5ff6 into mtgred:master May 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant