-
Notifications
You must be signed in to change notification settings - Fork 400
Elevation #8079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Elevation #8079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i didn't read any of the card changed or test changes, but the engine changes all looked good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot to unpack here. I'm not going to comment on the cards. Here are the features and bugfixes that got rolled in:
FEATURES/MAJOR CHANGES
ncigs
system got an overhaul. This means a lot of ice that can't do anything wont bother you to press useless buttons.:on-host
and:in-rfg
as a locations for events and static abilitieson-forfeit
events (this needs and auto-sets the:in-rfg
key to work)waiting-prompt
so people can't fire abilities while you try to discard cardslein fetch
command is now capable of using the-r --repo
and-b --branch
arguments to designate the repo (default isNoahTheDuke/netrunner-data
) and branch (default ismaster
) to pick the data from when running a fetchnew
while you're not selecting a card via a prompt.play-run-event
basically have to rip a continue more in their code to not brickBUGFIXES/QOL STUFF
this-card-is-run-source
def into macros, so we can easily check if a card is the run source. This should let us fix anything relating to doppelganger (eventually)def-helpers
for:(draw-loud state side eid card n) -> draws a card loudly
(run-server-ability server) -> runs a server
runs any server (choice)
runs any remote server
runs any central server
(run-server-from-choices-ability [choices]) -> runs a server from among the choices
(in-hand*? [state card]) -> is the card playable as if it was in hand
(all-cards-in-hand* state side) -> all cards playable as if they were in the hand for a side)
[n args]
[x]
(drain-credits draining-side victim-side qty (opt: multiplier) (opt: tags-gained) -> for use with siphon-like effects)
for our virus programs
is-deck-stacked? [state side expected-deck]
Is the deck stacked as we expect it to be? If you pick 3 cards out of a 30 card deck, that's still valid.provides-mu [cname x]
Does a cardcname
trivially providex
memory when installed by the runner.