Expected output stream with water found 2

[atecza-rmi]

find_output_stream() method in the Process class raises an error if more than one output stream containing water is detected. When the field attribute water_reinjection is turned on WaterTreatment subprocess is activated. This subprocess has 2 output stream destinations for water. The ProductionBoundary and WaterInjection. This is throwing the above error.

Potential solution: 1. delete the stream going to the production boundary 2. rename the type of water contained in the stream going either to production boundary or water injection.

[rjplevin]

WaterTreatment already define two content names:

		<Stream src="WaterTreatment" dst="ProductionBoundary">
			<Contains>water</Contains>
			<Contains>water for subsurface disposal</Contains>
		</Stream>

But water for subsurface disposal is not used in the code. So deleting <Contains>water</Contains> and changing "water" to "water for subsurface disposal" in WaterTreatment.__init__():

        if field.water_flooding or field.water_reinjection:
            self._required_outputs.append("water for subsurface disposal")

and in the run() method:

        if self.water_flooding or self.water_reinjection:
            water_to_reinjection = self.find_output_stream("water for subsurface disposal")

looks like it should fix it.
@mbarlow12 please take a look, too.

[mbarlow12]

I had a similar thought. I wasn't sure of a couple things:

• Is WaterInjection used for anything other than "water for subsurface disposal"?
• the ProductionBoundary is confusing to me given the logic in the run method. It looks like the intent is to only send water to WaterInjection and SteamGeneration. Can we remove <Stream src="WaterTreatment" dst="ProductionBoundary"> entirely? If so, we can keep "water" as the named contents for <Stream src="WaterTreatment" dst="WaterInjection">.

[rjplevin]

This is really @wennanlong's territory, since he implemented this Process. I don't understand why water would be sent to the production boundary.