IStateSelection memory leak (BindingFlags.FlattenHierarchy?)

[naice]

Hi,

I've found out that if you not derive directly from FluxorComponent (i have a base component public class LocalizedFluxorComponent : FluxorComponent) a injected IStateSelection creates a memory leak.

I haven't had time yet to dig entirely into the code but I am assuming thats a problem with reflection. But i guess that line

Fluxor/Source/Lib/Fluxor/StateSubscriber.cs

Line 64 in 392907b

t.GetProperties(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly)

might be the problem. So I was asking myself why won't you use BindingFlags.FlattenHierarchy to get all properties?

[mrpmorris]

Ah yes, I see the problem.

I think the correct fix is to remove DeclaredOnly.

If you fancy submitting a PR into https://github.com/mrpmorris/Fluxor/tree/release/5.6 I'll gladly accept it.

[naice]

I will do but i am currently unsure if this line really IS the problem. I am gonna check out and investigate.

For the moment I've setup a reproduction project (https://github.com/naice/FluxorMemoryLeak) if you switch between "Counter" and "Fetch data" and observe the console output (Browser) you can see instances stacking... (while clicking on UPDATE COUNT)

Edit: I have changed that method accordingly but that didnt fixed the issue.
Edit2: It also happens if the component is directly derived from FluxorComponent, currently I am not sure if its me thats using Fluxor wrong or if this is a bug, i am also not understanding why this is happening.

[naice]

Have you had time yet to look into my sample?

[mrpmorris]

Not yet, sorry

[mrpmorris]

Fixed in 5.6, thank you for letting me know and for creating the repo!