Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must remove IDisposable from transient classes #271

Closed
mrpmorris opened this issue Mar 10, 2022 · 0 comments · Fixed by #273
Closed

Must remove IDisposable from transient classes #271

mrpmorris opened this issue Mar 10, 2022 · 0 comments · Fixed by #273
Milestone
5.1

Comments

@mrpmorris
Copy link
Owner

mrpmorris commented Mar 10, 2022 •
edited
Loading

This is due to the fact that Microsoft Dependency injection holds on to a reference to everything that implements IDisposable, so when we new-up instances that are transient they never get garbage collected.

dotnet/runtime#66483
@mrpmorris mrpmorris linked a pull request Mar 10, 2022 that will close this issue
Remove IDisposable memory leak when using IStateSelector - closes #271 #273
Merged
mrpmorris added a commit that referenced this issue Mar 10, 2022
@mrpmorris
Remove IDisposable from IStateSubscriber #271
8f4e3b7
@mrpmorris mrpmorris added this to the 5.1 milestone Mar 11, 2022
@mrpmorris mrpmorris removed a link to a pull request Mar 11, 2022
Remove IDisposable memory leak when using IStateSelector - closes #271 #273
Merged
@mrpmorris mrpmorris linked a pull request Mar 11, 2022 that will close this issue
Remove IDisposable memory leak when using IStateSelector - closes #271 #273
Merged
@thierryrama thierryrama mentioned this issue Mar 13, 2022
Closed
mrpmorris added a commit that referenced this issue Mar 14, 2022
@mrpmorris
Remove IDisposable from IStateSubscriber #271
77aa790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

Remove IDisposable memory leak when using IStateSelector - closes #271 mrpmorris/Fluxor
1 participant
@mrpmorris