Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectd_graphite_encoder reads only one measurement #12

Closed
rashshah opened this issue Oct 26, 2015 · 8 comments
Closed

collectd_graphite_encoder reads only one measurement #12

rashshah opened this issue Oct 26, 2015 · 8 comments
Labels
Milestone

Comments

@rashshah
Copy link

collectd_graphite_encoder, when there are multiple measurements in kafka message, it adds only one measurement in influxdb. Seems like problem in for loop. Is it known issue?

@mre
Copy link
Owner

mre commented Oct 27, 2015

@rashshah thanks for the report. I will have a look asap.

@mre mre added the bug label Oct 27, 2015
@mre
Copy link
Owner

mre commented Oct 27, 2015

@rashshah could you give me an example message that is not working for you? This would make debugging a lot easier for me ;-)

@mre
Copy link
Owner

mre commented Oct 27, 2015

I think I found the bug. Please check in master.

@mre mre added this to the v0.8.0 milestone Oct 27, 2015
@rashshah
Copy link
Author

Changes looks good and works ok. One suggestion, in exception instead of "Error in encoder", say "empty line". Every message from kafka has the empty line in end, and this message will become annoying. Alternatively add check : "if line "

Pls release next version.

Regards,

rashmikant

@mre
Copy link
Owner

mre commented Oct 30, 2015

New version 0.7.2 is out now. :-)

@mre mre closed this as completed Oct 30, 2015
@rashshah
Copy link
Author

rashshah commented Nov 5, 2015

Thanks.

What is kafka-influxdb tightly coupled with requests=2.8.0? I have some other python packages, which uses 2.8.1, then kafka-influxdb throws error.

Traceback (most recent call last):
File "/usr/local/bin/kafka_influxdb", line 5, in
from pkg_resources import load_entry_point
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 3057, in
working_set = WorkingSet._build_master()
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 641, in _build_master
return cls._build_from_requirements(requires)
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 654, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 827, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'requests==2.8.0' distribution was not found and is required by kafka-influxdb

From: Matthias Endler <[email protected]mailto:[email protected]>
Reply-To: mre/kafka-influxdb <[email protected]mailto:[email protected]>
Date: Friday, October 30, 2015 at 1:03 AM
To: mre/kafka-influxdb <[email protected]mailto:[email protected]>
Cc: rashshah <[email protected]mailto:[email protected]>
Subject: Re: [kafka-influxdb] collectd_graphite_encoder reads only one measurement (#12)

New version 0.7.2 is out now. :-)

Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-152464969.

@mre
Copy link
Owner

mre commented Nov 5, 2015

@rashshah you're right. That shouldn't be the case. What I will do is follow the guideline on http://stackoverflow.com/a/7085000/270334. Will create a ticket for that. Thanks for the hint.

@mre
Copy link
Owner

mre commented Nov 5, 2015

@rashshah this should be fixed in master now. Would be glad for any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants