Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not resize expand_macro buffer #717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GordianDziwis
Copy link

This makes the expand_macro command a better fit for chaining it with layout commands.

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@GordianDziwis GordianDziwis changed the title Do not resize expand_macro buffer fix: do not resize expand_macro buffer Mar 31, 2025
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm fine with merging this, but to make the behaviour consistent, we should delete the ui.resize function (and its call sites) altogether.

This isn't a bug fix, so a fix: commit/PR prefix isn't appropriate here. It is, however, a breaking change, as it may come as an unwanted surprise to some users. So an appropriate commit message/PR title would be feat!(ui): don't resize split windows.
The commit body and PR description should explain how to reproduce the old behaviour (e.g. in a keymap).

I'm wondering if we should make the resize configurable (e.g. via a vim.g.rustaceanvim.tools.ui.resize option). I'm thinking YAGNI for now. We can add that if people complain.

Because it is a breaking change, I will hold off on merging this until I drop compatibility with Nvim 0.10 (which will be the next breaking change).

@mrcjkb mrcjkb enabled auto-merge (squash) April 6, 2025 00:14
This makes the `expand_macro` command a better fit for chaining it with layout commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants