Skip to content

fix(ftplugin): Properly sanitize hover actions debug command #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Tired-Fox
Copy link
Contributor

@Tired-Fox Tired-Fox commented Jan 22, 2024

fixes #179 by sanitizing the actual command from hover actions debug.

I have tested this manually on my local machine. The final command when from run to build after sanitization and dap was run.

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@Tired-Fox Tired-Fox changed the title bugfix(ftplugin): Properly sanitize hover actions debug command fix(ftplugin): Properly sanitize hover actions debug command Jan 22, 2024
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey 👋

Thanks for the fix and the detailed report 😄
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover actions debug command will run instead of build
2 participants