Skip to content

Fallback to tiff if libtiff is not found on macOS and Windows #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

radarhere
Copy link

Suggestion for python-pillow#8016

You can see that some of the jobs on your PR are failing because libtiff isn't found on macOS and Windows - https://github.com/python-pillow/Pillow/actions/runs/8838868584/job/24276907851?pr=8016#step:5:8488

If you look at the original setup.py code, you will see that it should fallback to tiff if libtiff isn't found, but your PR missed that. This fixes it.

Copy link
Owner

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Indeed, I messed up the logic here - I blame the late hour...
What is the policy here for merging a PR into another PR (e. g. merge, rebase or squash)?

@radarhere
Copy link
Author

Merging is fine.
Rebase or squashing is ok if it doesn't make existing comments/review harder to follow.

So in this case, whatever you like really.

@mrbean-bremen mrbean-bremen merged commit 747a9b9 into mrbean-bremen:debug-build Apr 26, 2024
@radarhere radarhere deleted the debug-build branch April 26, 2024 06:22
mrbean-bremen pushed a commit that referenced this pull request Jul 25, 2024
mrbean-bremen pushed a commit that referenced this pull request Jul 25, 2024
mrbean-bremen pushed a commit that referenced this pull request Jul 25, 2024
Do not import numpy.typing unless TYPE_CHECKING
mrbean-bremen pushed a commit that referenced this pull request Jul 25, 2024
Co-authored-by: Andrew Murray <[email protected]>
radarhere pushed a commit that referenced this pull request Nov 30, 2024
Renamed variable for first part of splitext to root
radarhere pushed a commit that referenced this pull request Nov 30, 2024
Disable platform guessing instead of adding dependencies-prefix
radarhere pushed a commit that referenced this pull request Nov 30, 2024
mrbean-bremen pushed a commit that referenced this pull request May 14, 2025
Do not create temporary file if no utility is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants