mac/vulkan: error out on context creation without an NSApplication #14539
Conversation
|
Download the artifacts for this pull request: |
Both. The idea is to test if things init/deinit multiple times without crashing / leaking memory. I don't impose strict rules on this test, because I'm aware that most things will not work anyway on CI without display/gpu. Locally though I tested with multiple different vo and so on, just to see what happens. In summary, this PR is good change. But at the same time extending this to make the initialization process go further would be beneficial too, to bring more coverage on this one, not required though. |
if no NSApplication has been initialized, applications using Appkit functionality are not supposed to work properly or just deadlock indefinitely. properly error out on macvk context creation in that case.
@kasper93 just wonder if this is what you had in mind. was the test supposed to test a vo on every platform or is it more like a test that libmpv init works properly and if no vo can be initialised it should error out gracefully?
this does the latter now on macOS and errors out properly if the context can't be initialised because no NSApplication environment is found.
if we want the former, we would need to init an NSApplication in the test.