Skip to content

Don’t skip glyph 0 in cmap. #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

brendandahl
Copy link
Contributor

Fixes #8234.

Hopefully this won't break anything since our support for notdef is better these days.

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/a9d0645ad5bc9c6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/234cfd503c5917c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/234cfd503c5917c/output.txt

Total script time: 23.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 5, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/a9d0645ad5bc9c6/output.txt

Total script time: 30.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a lot simpler than I imagined :-)
Thank you for the patch!

@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2017

From: Bot.io (Linux)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/77e57ed06bdcd7e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2017

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/c22561d3f084ee2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/c22561d3f084ee2/output.txt

Total script time: 23.06 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 6, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/77e57ed06bdcd7e/output.txt

Total script time: 28.82 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus merged commit a662d26 into mozilla:master Apr 6, 2017
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants