Skip to content

Widget annotations: do not crash if Parent is not a dictionary during field name construction (issue 8143) #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Mar 9, 2017

Fixes #8143.

during field name construction (issue 8143)
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2017

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6cb4895761bb8ac/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/6cb4895761bb8ac/output.txt

Total script time: 2.15 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests.
Thanks for the quick fix!

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3ba85e775cfafec/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/fea25b01d20fcc9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/fea25b01d20fcc9/output.txt

Total script time: 22.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/3ba85e775cfafec/output.txt

Total script time: 28.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit fc5810c into mozilla:master Mar 9, 2017
@timvandermeij timvandermeij deleted the issue-8143 branch March 9, 2017 23:40
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Widget annotations: do not crash if `Parent` is not a dictionary during field name construction (issue 8143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants