Don't include web/compatibility.js in the output for gulp lib (PR 8120 follow-up)
#8130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 8120 follow-up) First of all, `compatibility.js` is already available in `lib/shared/compatibility.js`. Second of all, as can be seen in mozilla/pdfjs-dist@9142301#diff-9432ebaa58e10ab02874fcb86f689caa, the `lib/web/compatibility.js` file cannot work since the `require` statement isn't compatible with the output of `gulp lib`.
timvandermeij
approved these changes
Mar 4, 2017
|
Good catch, thanks! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…mpatibility Don't include `web/compatibility.js` in the output for `gulp lib` (PR 8120 follow-up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all,
compatibility.jsis already available inlib/shared/compatibility.js. Second of all, as can be seen in mozilla/pdfjs-dist@9142301#diff-9432ebaa58e10ab02874fcb86f689caa, thelib/web/compatibility.jsfile cannot work since therequirestatement isn't compatible with the output ofgulp lib.