Further adjust the heuristics used to detect OpenType font files with CFF data, to ensure that all Type0 fonts are handled the same way regardless of font Subtype (issue 7901) #7904
Conversation
… CFF data, to ensure that all Type0 fonts are handled the same way regardless of font Subtype (issue 7901) Changing this particular code makes me somewhat nervous about regressions, since PR 5770 necessitated the follow-up PR 6270. However, the patch passes all tests added in those PRs (and obviously all other tests). Furthermore, I've manually checked all the issues/bugs referenced in PRs 5770 and 6270 without finding any issues. **Please note:** This patch fixes *only* the font bug, not the SVG conversion, present on pages two and three of the PDF file in issue 7901.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f2cdd953d7ad78d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/52f4e678010f5ff/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/52f4e678010f5ff/output.txt Total script time: 25.57 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f2cdd953d7ad78d/output.txt Total script time: 25.73 mins
|
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://107.21.233.14:8877/53ed09a4bc9e150/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://107.22.172.223:8877/05f0527f341b628/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/53ed09a4bc9e150/output.txt Total script time: 25.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/05f0527f341b628/output.txt Total script time: 25.43 mins
|
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2c91bae798871e4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/63e20e5f7076b13/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/63e20e5f7076b13/output.txt Total script time: 25.36 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2c91bae798871e4/output.txt Total script time: 26.04 mins
|
|
Thanks! |
Further adjust the heuristics used to detect OpenType font files with CFF data, to ensure that all Type0 fonts are handled the same way regardless of font Subtype (issue 7901)
Changing this particular code makes me somewhat nervous about regressions, since PR #5770 necessitated the follow-up PR #6270.
However, the patch passes all tests added in those PRs (and obviously all other tests). Furthermore, I've manually checked all the issues/bugs referenced in PRs #5770 and #6270 without finding any issues.
Please note: This patch fixes only the font bug, not the SVG conversion, present on pages two and three of the PDF file in issue #7901.