Skip to content

Add a enhanceTextSelection preference #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2016
Merged

Add a enhanceTextSelection preference #7609

merged 1 commit into from
Sep 9, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

Please note that this is a hack, but I think that it should be OK for now to atleast get the preference landed. Refer to the code comment for further information.

Re: issue #7584 and PR #7586.

Please note that this is a hack, but I think that it should be OK for now to atleast get the preference landed. Refer to the code comment for further information.

Re: issue 7584 and PR 7586.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2016

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b94b897ee56a795/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b94b897ee56a795/output.txt

Total script time: 1.26 mins

Published

@timvandermeij timvandermeij merged commit 22c7ff4 into mozilla:master Sep 9, 2016
@timvandermeij
Copy link
Contributor

timvandermeij commented Sep 9, 2016

Thank you! I agree that this is fine for now so we can actually work with it. The descriptive comment is good for improving this later on if required.

@Snuffleupagus Snuffleupagus deleted the enhanceTextSelection-pref-hack branch September 9, 2016 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants