Check that Type1C fonts does not actually contain OpenType font files (issue 7598) #7600
Conversation
… (issue 7598) This patch is yet another instalment in the (never ending) series of patches for PDF files that specify completely incorrect Type/Subtype for its fonts. In this case Type1/Type1C, when in fact OpenType would have been correct. Fixes 7598.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/06901e2cb3c8c7e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/06901e2cb3c8c7e/output.txt Total script time: 1.78 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ac1846bffc14d36/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/2ee1c7816311798/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/2ee1c7816311798/output.txt Total script time: 23.54 mins
Image differences available at: http://107.22.172.223:8877/2ee1c7816311798/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/ac1846bffc14d36/output.txt Total script time: 38.32 mins
Image differences available at: http://107.21.233.14:8877/ac1846bffc14d36/reftest-analyzer.html#web=eq.log |
|
Given that this isn't the first, and probably won't be the last, time that we've had to adjust the Type/Subtype because the PDF generator lies, we might want to consider simply ignoring that information and always check the font file itself instead. I've got a WIP patch that does this and, provided that it actually passes all tests locally, I'd be happy to submit that one as a follow-up after the current PR lands. |
|
r+ |
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5766a6ec66989f0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b41da0eb8260f51/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b41da0eb8260f51/output.txt Total script time: 24.49 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5766a6ec66989f0/output.txt Total script time: 36.39 mins
|
|
Nice work! |
|
(Feel free to make a PR for the follow-up patch you mentioned if you think it helps to prevent further issues.) |
This patch is yet another instalment in the (never ending) series of patches for PDF files that specify completely incorrect Type/Subtype for its fonts. In this case Type1/Type1C, when in fact OpenType would have been correct.
Fixes #7598.
Edit: Perhaps marginally easier reviewing with https://github.com/mozilla/pdf.js/pull/7600/files?w=1.
This change is