Skip to content

Change the warn to info in recoverGlyphName to reduce the console spam #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2016
Merged

Change the warn to info in recoverGlyphName to reduce the console spam #7479

merged 1 commit into from
Jul 9, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jul 9, 2016

After PR #7441, where recoverGlyphName is used a lot more than before, many PDF files will generate a lot of warnings the console. For normal usage, compared to debugging/development, this is probably more annoying than helpful.

…le spam

After PR 7441, where `recoverGlyphName` is used a lot more than before, many PDF files will generate a lot of warnings the console. For normal usage, compared to debugging/development, this is probably more annoying than helpful.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jul 9, 2016

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5d198471d6b9baf/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 9, 2016

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fe69aebb2626a23/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 9, 2016

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/49761d84ed35e3d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 9, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/fe69aebb2626a23/output.txt

Total script time: 22.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 9, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/49761d84ed35e3d/output.txt

Total script time: 28.04 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d728651 into mozilla:master Jul 9, 2016
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the recoverGlyphName-warn-to-info branch July 9, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants