Moves DEFAULT_PREFENCES into JSON format. #7317
Conversation
yurydelendik
force-pushed
the
move-defaultprefs
branch
from
f9308d3 to
91166b5
Compare
| this._readFromStorage(DEFAULT_PREFERENCES).then(function(prefObj) { | ||
| return this.initializedPromise = defaultPreferences.then( | ||
| function (defaults) { | ||
| this.defaults = defaults; |
There was a problem hiding this comment.
Since the defaults are now exposed on Preferences, can we use Object.freeze(defaults) here to prevent outside tampering with the default values?
There was a problem hiding this comment.
Yes, we can do that
yurydelendik
force-pushed
the
move-defaultprefs
branch
from
91166b5 to
f4bf183
Compare
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/cfa637fe8eff645/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/cfa637fe8eff645/output.txt Total script time: 1.77 mins Published |
| @@ -82,8 +102,8 @@ var Preferences = { | |||
| */ | |||
| reset: function preferencesReset() { | |||
| return this.initializedPromise.then(function() { | |||
| this.prefs = Object.create(DEFAULT_PREFERENCES); | |||
| return this._writeToStorage(DEFAULT_PREFERENCES); | |||
| this.prefs = Object.create(this.defaults); | |||
There was a problem hiding this comment.
It seems that my previous comment causes issues here, since after a reset, attempting to set a new value fails.
I still think that it makes a certain amount of sense to freeze the defaults, so could we instead change this line to this.prefs = Object.assign({}, this.defaults);, to fix this issue?
|
r=me, with the comment addressed. |
|
|
yurydelendik
force-pushed
the
move-defaultprefs
branch
from
f4bf183 to
df10513
Compare
Makes it easier to address #7192 , e.g.
PDFJSDev.json('file.json')will be inlining loaded object.