Fixes some static analysis warnings and recommendations #7281
Conversation
yurydelendik
commented
May 2, 2016
yurydelendik
commented
- Useless conditional
- Superfluous trailing arguments
- Useless assignment to local variable
- Misspelled identifier
- JSDoc tag for non-existent parameter
| var string32 = sharedUtil.string32; | ||
| var warn = sharedUtil.warn; | ||
| var MissingDataException = sharedUtil.MissingDataException; | ||
| var Stream = coreStream.Stream; | ||
| var Lexer = coreParser.Lexer; | ||
| var getGlyphsUnicode = coreGlyphList.getGlyphsUnicode; | ||
| var getDingbatsGlyphsUnicode = coreGlyphList.getDingbatsGlyphsUnicode; | ||
| var ISOAdobeCharset = coreCharsets.ISOAdobeCharset; |
There was a problem hiding this comment.
We can probably remove the coreCharsets import now that these lines are gone. cff_parser already imports it for us.
There was a problem hiding this comment.
You are right. Thanks.
* Useless conditional * Superfluous trailing arguments * Useless assignment to local variable * Misspelled identifier * JSDoc tag for non-existent parameter
yurydelendik
force-pushed
the
static-warnings
branch
from
d2f1900 to
32ce369
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c52238d835f38d2/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c52238d835f38d2/output.txt Total script time: 1.07 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/372ae8438cd9834/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0141c58562e3bbf/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/372ae8438cd9834/output.txt Total script time: 21.43 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/0141c58562e3bbf/output.txt Total script time: 27.62 mins
|
|
Awesome work! |
