Prevent "Prefixed Fullscreen API is deprecated." warnings in the MOZCENTRAL version (issue 7270) #7273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -419,10 +419,14 @@ var PDFViewerApplication = { | |||
| var support = !!(doc.requestFullscreen || doc.mozRequestFullScreen || | |||
| doc.webkitRequestFullScreen || doc.msRequestFullscreen); | |||
|
|
|||
| //#if MOZCENTRAL | |||
There was a problem hiding this comment.
I'm thinking we can include the check above it the #if too. Can you make MOZCENTRAL section as var support = document.fullscreenEnabled === true;.
There was a problem hiding this comment.
Just so I understand, do you want to get rid of the !!doc.requestFullscreen part, or did you mean something like the following?
//#if MOZCENTRAL
// var support = !!doc.requestFullscreen && document.fullscreenEnabled === true;
//#else
...
//#endifThere was a problem hiding this comment.
yes, doc.requestFullscreen will present anyway, also document.fullscreenEnabled === true will make sure it's enabled and at the same moment will check if API is present (=== true) is a key :)
There was a problem hiding this comment.
Sounds good, it's fixed now.
…ENTRAL version (issue 7270) We're already, since quite some time, using the standard Fullscreen API provided that it's available in the browser. The warning is only caused by the code that checks if the Fullscreen API is supported. This patch uses a simple preprocessor tag to avoid the warning, since I'm assuming that in general, we want to try and remain backwards compatible with the prefixed versions of the Fullscreen API. Fixes 7270.
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already, since quite some time, using the standard Fullscreen API provided that it's available in the browser. The warning is only caused by the code that checks if the Fullscreen API is supported.
This patch uses a simple preprocessor tag to avoid the warning, since I'm assuming that in general, we want to try and remain backwards compatible with the prefixed versions of the Fullscreen API.
Fixes #7270.