Moves bundle target/task to gulpfile.js #7240
Conversation
|
|
||
| var BUILD_DIR = 'build/'; | ||
| var L10N_DIR = 'l10n/'; | ||
|
|
||
| require('./make.js'); | ||
| var makeFile = require('./make.js'); | ||
| var bundle = makeFile.bundler; |
There was a problem hiding this comment.
Shouldn't it be makeFile.bundle instead?
yurydelendik
force-pushed
the
bundle
branch
6 times, most recently
from
0e848b2 to
ae989b8
Compare
| @@ -2179,7 +2179,7 @@ window.addEventListener('afterprint', function afterPrint(evt) { | |||
|
|
|||
| exports.PDFViewerApplication = PDFViewerApplication; | |||
|
|
|||
| // TODO remove circular reference of pdfjs-web/secondary_toolbar on app. | |||
| //// TODO remove circular reference of pdfjs-web/secondary_toolbar on app. | |||
There was a problem hiding this comment.
Needed because our preprocessor removes this comment -- was not an issue since in the past it was a two stage preprocessing. See viewer.js
| [COMMON_WEB_FILES_PREPROCESS, MOZCENTRAL_CONTENT_DIR + '/web'], | ||
| [BUILD_DIR + 'viewer.js', MOZCENTRAL_CONTENT_DIR + '/web'], |
There was a problem hiding this comment.
Why can't we move this to the copy section above, just like the other targets?
|
/botio preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5f050352b6a457e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/72529af7d1e6ce7/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5f050352b6a457e/output.txt Total script time: 1.06 mins Published |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/72529af7d1e6ce7/output.txt Total script time: 1.31 mins Published |
|
Nice work! |
|
Looking at the latest diff for |
Add fixes double processing of the bundled files -- the
//#expand __BUNDLE__content was not processed first time.Ref #7062