Removes core/stream circular dependency on core/parser. #7100
Conversation
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/573bfe59367e542/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ce3165e7e6cb6ff/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/ce3165e7e6cb6ff/output.txt Total script time: 19.97 mins
Image differences available at: http://107.22.172.223:8877/ce3165e7e6cb6ff/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/573bfe59367e542/output.txt Total script time: 23.86 mins
Image differences available at: http://107.21.233.14:8877/573bfe59367e542/reftest-analyzer.html#web=eq.log |
| @@ -2337,12 +2339,12 @@ var CCITTFaxStream = (function CCITTFaxStreamClosure() { | |||
| while (this.inputBits < n) { | |||
| if ((c = this.str.getByte()) === -1) { | |||
| if (this.inputBits === 0) { | |||
| return EOF; | |||
| return undefined; | |||
There was a problem hiding this comment.
Should be return ccittEOF; instead.
|
r=me, with the comment addressed and passing tests. Thanks for cleaning this up! |
yurydelendik
force-pushed
the
stream-wo-parser
branch
from
89cab45 to
6038c23
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/cd9ab0eae5b7878/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/63b80b5846ac49c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/cd9ab0eae5b7878/output.txt Total script time: 20.29 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/63b80b5846ac49c/output.txt Total script time: 22.09 mins
|
Removes core/stream circular dependency on core/parser.
We were using EOF as an object. Making it a number might make CCITT faster (easier for JIT).
Partially addresses #6777