Skip to content

Map missing glyphs to the notdef glyph for TrueType (3, 1) fonts regardless if the 'post' table is defined or not (issue 6889) #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #6889.

Edit: I pushed a new commit only to fix a typo in the commit message, no functional changes were made!

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/faeac752c2b64bb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0c48dcc709ab5b3/output.txt

@Snuffleupagus Snuffleupagus changed the title Map missing glyphs to the notdef glyph for TrueType fonts regardless if the ' post' table defined or not (issue 6889) Map missing glyphs to the notdef glyph for TrueType fonts regardless if the ' post' table is defined or not (issue 6889) Jan 17, 2016
@Snuffleupagus Snuffleupagus changed the title Map missing glyphs to the notdef glyph for TrueType fonts regardless if the ' post' table is defined or not (issue 6889) Map missing glyphs to the notdef glyph for TrueType (3, 1) fonts regardless if the ' post' table is defined or not (issue 6889) Jan 17, 2016
…gardless if the 'post' table is defined or not (issue 6889)
@Snuffleupagus Snuffleupagus changed the title Map missing glyphs to the notdef glyph for TrueType (3, 1) fonts regardless if the ' post' table is defined or not (issue 6889) Map missing glyphs to the notdef glyph for TrueType (3, 1) fonts regardless if the 'post' table is defined or not (issue 6889) Jan 17, 2016
@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/faeac752c2b64bb/output.txt

Total script time: 21.33 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/0c48dcc709ab5b3/output.txt

Total script time: 21.40 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/20a6d5dd16fdaa6/output.txt

@timvandermeij
Copy link
Contributor

Awesome, thank you for working on this so quickly! I can confirm that this fixes the issue.

@yurydelendik
Copy link
Contributor

/botio makeref

Looks good. Thank you.

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e41d7f05d7d0db0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/1b60052a8fba484/output.txt

yurydelendik added a commit that referenced this pull request Jan 20, 2016
Map missing glyphs to the `notdef` glyph for TrueType (3, 1) fonts regardless if the 'post' table is defined or not (issue 6889)
@yurydelendik yurydelendik merged commit 0aa373c into mozilla:master Jan 20, 2016
@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/e41d7f05d7d0db0/output.txt

Total script time: 20.93 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/1b60052a8fba484/output.txt

Total script time: 21.69 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-6889 branch January 21, 2016 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded font displayed as random characters
5 participants