Use adjustWidths for TrueType fonts if we handle them as OpenType (issue 5027, issue 5084, issue 6556, bug 1204903)
#6736
Conversation
…issue 5027, issue 5084, issue 6556, bug 1204903) In `Font_checkAndRepair` we can decide that a font isn't TrueType, and instead parse it as CFF. In that case it's quite possible that the `fontMatrix` will be changed, and without calling `adjustWidths` we're failing to update the glyph widths correctly. Fixes 5027. Fixes 5084. Fixes 6556. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1204903.
|
@timvandermeij Thanks for asking lots of questions about this on IRC! I've updated the patch to hopefully cover all cases where the /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/84e6668ced61fd5/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a61e613beba4179/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/84e6668ced61fd5/output.txt Total script time: 19.25 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a61e613beba4179/output.txt Total script time: 20.07 mins
|
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/fff2adc7c54787c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/fff2adc7c54787c/output.txt Total script time: 1.29 mins Published |
|
This looks better to me! Let's remake the reference images just to be sure. /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/14eb3a3068b58cf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/dcd9de7852696db/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/dcd9de7852696db/output.txt Total script time: 19.11 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/14eb3a3068b58cf/output.txt Total script time: 20.00 mins
|
Use `adjustWidths` for TrueType fonts if we handle them as OpenType (issue 5027, issue 5084, issue 6556, bug 1204903)
|
Thank you for the patch! |
In
Font_checkAndRepairwe can decide that a font isn't TrueType, and instead parse it as CFF. In that case it's quite possible that thefontMatrixwill be changed, and without callingadjustWidthswe're failing to update the glyph widths correctly.Fixes #5027.
Fixes #5084.
Fixes #6556.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1204903.
Edit: Also fixes #5213.