Skip to content

Fixes canvas state after smask group ends. #6720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

yurydelendik
Copy link
Contributor

Fixes #5712 and #6032 regression (Probably more). Problem was that smask state was set after fill/stroke colors are changed.

@Snuffleupagus
Copy link
Collaborator

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c82ed7fe9814101/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/edb69862d4a6106/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/cc9c246751b527c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/cc9c246751b527c/output.txt

Total script time: 19.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/edb69862d4a6106/output.txt

Total script time: 20.55 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator

Looks good, thank you!

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b741945ae9b532f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3f8cc804964374f/output.txt

Snuffleupagus added a commit that referenced this pull request Dec 3, 2015
Fixes canvas state after smask group ends.
@Snuffleupagus Snuffleupagus merged commit e2aca38 into mozilla:master Dec 3, 2015
@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/b741945ae9b532f/output.txt

Total script time: 19.24 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/3f8cc804964374f/output.txt

Total script time: 19.92 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

yurydelendik added a commit to yurydelendik/pdf.js that referenced this pull request Dec 5, 2015
yurydelendik added a commit that referenced this pull request Dec 5, 2015
Replaces test for #6720 to fix botio-linux slow script.
@yurydelendik yurydelendik deleted the smask-state branch January 28, 2016 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants