Better spacing in text layer. #6588
Conversation
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/69081d6b39fd047/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/fe827d75b5732d7/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/fe827d75b5732d7/output.txt Total script time: 19.17 mins
Image differences available at: http://107.22.172.223:8877/fe827d75b5732d7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/69081d6b39fd047/output.txt Total script time: 20.11 mins
Image differences available at: http://107.21.233.14:8877/69081d6b39fd047/reftest-analyzer.html#web=eq.log |
|
Generally this is looking like a really nice improvement, but I happened to notice that in It might be an idea to add |
This is a really bad case for us -- it overprints text at the same spot: first is prints "log log", then variable names, and after that operators. That makes it a really bad (I would say corrupted) PDF since it's not preserving a reading order. We can safely discard this a regression (it did not work properly in first place), and we probably have few issues already opened for this particular case. |
| "file": "pdfs/issue6019.pdf", | ||
| "md5": "7a2e5dda3b0fc5c2e9060e378a8cdc4e", | ||
| "rounds": 1, | ||
| "type": "eq" |
There was a problem hiding this comment.
Shouldn't this be a text test instead?
There was a problem hiding this comment.
Yes, it is a text test. Thank you.
That seems fine by me, thanks for the explanation! However, I'm also wondering about the test changes in |
|
Hmmm, that tough one, looking at the screenshot below I might say that #5995 was a regression ("after" means after #6588 patch):
Looking at start of the letters, #5995 started moving all letters to the right due to artificial padding at the front of the text run. Per spec: "When the glyph for each character in the string is rendered, Tc shall be added ..." IMHO to fix #5972, is last char and word spacing is remembered to be used as a right padding of the div block in the text layer. What do you prefer: address it here, re-open #5972 or perhaps in #6590? |
| @@ -1807,7 +1814,7 @@ | |||
| "link": false, | |||
| "type": "load", | |||
| "password": "\u00E6\u00F8\u00E5", | |||
| "about": "The password (���) is UTF8 encoded." | |||
| "about": "The password (���) is UTF8 encoded." | |||
There was a problem hiding this comment.
Nit: there appears to be some kind of encoding issue here.
I've got no real preference; do whatever you think is the easiest :-) If you choose to handle it in #6590, feel free to land the current PR with |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/74d459636fca8b9/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/15296db5c959b5a/output.txt |
Better spacing in text layer.
|
@Snuffleupagus thanks for review |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/74d459636fca8b9/output.txt Total script time: 19.40 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/15296db5c959b5a/output.txt Total script time: 20.28 mins
|
Alternative solution for #6019 (and fixes its PDF; attaching cleaned up version by @Snuffleupagus )
Improved /test/pdfs/pdf.pdf page 3 layout:
