Skip to content

Avoid more allocations for RTL text in bidi.js #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Avoid more allocations for RTL text in bidi.js #6357

merged 1 commit into from
Aug 31, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Instead of building the resulting string char-by-char for RTL text, which is inefficient, we can just as well join the chars array.

Instead of building the resulting string char-by-char for RTL text, which is inefficient, we can just as well `join` the `chars` array.
@CodingFabian
Copy link
Contributor

looks good to me, +1 for merging

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f5d19e23e16843c/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fa847ab699b9cdc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/028e1cb6400c91b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/fa847ab699b9cdc/output.txt

Total script time: 18.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/028e1cb6400c91b/output.txt

Total script time: 19.54 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Aug 31, 2015
Avoid more allocations for RTL text in bidi.js
@timvandermeij timvandermeij merged commit 0020f33 into mozilla:master Aug 31, 2015
@timvandermeij
Copy link
Contributor

Nice one, thank you!

@Snuffleupagus Snuffleupagus deleted the bidi-result branch August 31, 2015 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants