-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Avoid more allocations for RTL text in bidi.js #6357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of building the resulting string char-by-char for RTL text, which is inefficient, we can just as well `join` the `chars` array.
looks good to me, +1 for merging |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f5d19e23e16843c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f5d19e23e16843c/output.txt Total script time: 0.69 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/fa847ab699b9cdc/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/028e1cb6400c91b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/fa847ab699b9cdc/output.txt Total script time: 18.66 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/028e1cb6400c91b/output.txt Total script time: 19.54 mins
|
Avoid more allocations for RTL text in bidi.js
Nice one, thank you! |
Instead of building the resulting string char-by-char for RTL text, which is inefficient, we can just as well
join
thechars
array.