Skip to content

Skip mapping of CIDFontType2 glyphs when the font either has a |IdentityToUnicodeMap| or a |toUnicodeMap| with 65536 elements (issue 5677) #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

This patch slightly extends the heuristics used when trying to skip mapping of missing glyphs.

Fixes #5677.

…ityToUnicodeMap| or a |toUnicodeMap| with 65536 elements (issue 5677)

This patch slightly extends the heuristics used when trying to skip mapping of missing glyphs.

Fixes 5677.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/b94af95893f12ef/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/004b84a6201ac0f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/b94af95893f12ef/output.txt

Total script time: 18.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/004b84a6201ac0f/output.txt

Total script time: 18.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/06b2bd12de5b6ee/output.txt

@timvandermeij
Copy link
Contributor

I can confirm that this fixes the issue and the patch looks really good to me. Still I would like @yurydelendik or @brendandahl to take a final look and merge it.

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2015

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2d260b06c8f0189/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2015

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9963573b1619b8e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/2d260b06c8f0189/output.txt

Total script time: 18.12 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 1, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9963573b1619b8e/output.txt

Total script time: 18.46 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

brendandahl added a commit that referenced this pull request Jul 1, 2015
Skip mapping of CIDFontType2 glyphs when the font either has a |IdentityToUnicodeMap| or a |toUnicodeMap| with 65536 elements (issue 5677)
@brendandahl brendandahl merged commit d8e2014 into mozilla:master Jul 1, 2015
@Snuffleupagus Snuffleupagus deleted the issue-5677-v2 branch July 1, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants