Tweak the PDFLinkService a bit #6063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `PDFLinkService` requires access to a `PDFHistory` instance in order for it to work correctly (and to avoid errors). If we want `PDFLinkService` to be more useful in custom viewers, I don't think that we actually want to force it to have a `PDFHistory` instance. Hence this patch, which contains a very simply approach to make `PDFHistory` optional.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ec3823137365fab/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ec3823137365fab/output.txt Total script time: 0.97 mins Published |
|
Looks good to me. |
yurydelendik
added a commit
that referenced
this pull request
May 29, 2015
…istory Tweak the PDFLinkService a bit
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of small follow-ups to PR #5971.
Currently
PDFLinkServicerequires access to aPDFHistoryinstance in order for it to work correctly (and to avoid errors). If we wantPDFLinkServiceto be more useful in custom viewers, I don't think that we actually want to force it to have aPDFHistoryinstance.Hence this patch, which contains a very simply approach to make
PDFHistoryoptional.Edit: Even simpler reviewing with https://github.com/mozilla/pdf.js/pull/6063/files?w=1.