Extract correct PDF format version from the catalog #6046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you squash the commits into one commit (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits)? |
The 'Version' field of the most recent document catalog, if present, is intended to supersede the value in the file prologue. This is significant for incrementally-built PDF documents and generators that emit a low version in the prologue and later apply a format version based on PDF features used, such as Apple's CoreGraphics/Quartz PDF backend. Fixes the internal version variable, as well as the PDFFormatVersion reported by the API and consumed by viewers.
|
Fix and test case are now squashed into one commit and rebased. |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/80c0d6e0142718f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b8e2152c48919f8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/80c0d6e0142718f/output.txt Total script time: 17.92 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b8e2152c48919f8/output.txt Total script time: 18.19 mins
|
yurydelendik
added a commit
that referenced
this pull request
May 27, 2015
Extract correct PDF format version from the catalog
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Version' field of the most recent document catalog, if present, is
intended to supersede the value in the file prologue.
This is significant for incrementally-built PDF documents and generators that
emit a low version in the prologue and later apply a format version based on
PDF features used, such as Apple's CoreGraphics/Quartz PDF backend.
Fixes the internal version variable, as well as the PDFFormatVersion reported
by the API and consumed by viewers.