Don't map glyphs to certain problematic Thai/Lao Unicode locations (issue 5994) #5998
Conversation
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/5004497bdf85edb/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/5004497bdf85edb/output.txt Total script time: 0.78 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9f6ca7f9c8dc6c2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d4e13b9f06f1bdf/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d4e13b9f06f1bdf/output.txt Total script time: 17.99 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/9f6ca7f9c8dc6c2/output.txt Total script time: 18.27 mins
Image differences available at: http://107.21.233.14:8877/9f6ca7f9c8dc6c2/reftest-analyzer.html#web=eq.log |
…ssue 5994) *This patch depends on PR 5990.* According to https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/hb-ot-shape-fallback.cc#38, certain Thai/Lao characters are treated as special by the font shaping code in Firefox. Further down in that file, https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/hb-ot-shape-fallback.cc#216, the vertical position of glyphs is modified, which should thus explain why some glyphs end up in the wrong position in the PDF file. Fixes 5994.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/525c0590e2f997d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/dad164f19ea42df/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/525c0590e2f997d/output.txt Total script time: 18.08 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/dad164f19ea42df/output.txt Total script time: 18.16 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3647633833e0a61/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7962fb5593f276d/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/3647633833e0a61/output.txt Total script time: 1.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7962fb5593f276d/output.txt Total script time: 18.24 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/af54f5bf20cac70/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/af54f5bf20cac70/output.txt Total script time: 18.09 mins
|
Don't map glyphs to certain problematic Thai/Lao Unicode locations (issue 5994)
This patch depends on PR #5990.According to https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/hb-ot-shape-fallback.cc#38, certain Thai/Lao characters are treated as special by the font shaping code in Firefox.
Further down in that file, https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/hb-ot-shape-fallback.cc#216, the vertical position of glyphs is modified, which should thus explain why some glyphs end up in the wrong position in the PDF file.
Fixes #5994.
TODO: Add a reduced test-case (once I manage to create one that works).