Refactor document properties overlay #5959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Snuffleupagus Thank you for the thorough review! I will make the changes in a new set of commits. |
timvandermeij
force-pushed
the
document-properties-class
branch
3 times, most recently
from
a5fee36 to
c02c33d
Compare
This patch: - Puts public methods at the top of the file - Puts private methods below the public methods and marks them with an underscore - Adds JSDoc comments to the class - Adds setDocumentAndUrl to avoid having to handle that in `viewer.js`
timvandermeij
force-pushed
the
document-properties-class
branch
from
c02c33d to
7c04ee2
Compare
| this.pdfDocument = null; | ||
|
|
||
| // Bind the event listener for the Close button. | ||
| if (options.closeButton) { |
There was a problem hiding this comment.
Sorry about not catching this earlier, but the button is missing from the JSDoc comment above. {HTMLButtonElement} would probably be an OK type to use.
The PR is good to go once this is addressed.
There was a problem hiding this comment.
Addressed in the most recent commit.
This patch: - Simplifies the way fields are passed to the document properties overlay - Simplifies the way fields are filled internally in the document properties overlay - Avoids passing a document properties reference to the secondary toolbar
timvandermeij
force-pushed
the
document-properties-class
branch
from
7c04ee2 to
6abf3d6
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/70271673518e5ff/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/70271673518e5ff/output.txt Total script time: 0.80 mins Published |
|
Looks great, thank you! |
Snuffleupagus
added a commit
that referenced
this pull request
Apr 27, 2015
Refactor document properties overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows a similar pattern as other refactoring patches. The aim here is to make the document properties code more class-like, simplifying field passing/handling and avoiding passing a reference to the secondary toolbar.
Using the
?w=1URL parameter makes review easier.