Skip to content

Remove no longer needed hacks that enable spacebar scrolling in Firefox (issue 3498) #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Note: We probably want to hold off merging this a few days (or maybe a week), to ensure that the upstream patch sticks. Edit: https://bugzilla.mozilla.org/show_bug.cgi?id=915962#c14.

Now that bug 915962 has landed, we no longer need any hacks to enable spacebar scrolling in Firefox.

Fixes #3498.

…ox (issue 3498)

Now that [bug 915962](https://bugzilla.mozilla.org/show_bug.cgi?id=915962) has landed, we no longer need any hacks to enable <kbd>spacebar</kbd> scrolling in Firefox.

Fixes 3498.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f845a5bdf63a3ea/output.txt

timvandermeij added a commit that referenced this pull request Apr 27, 2015
Remove no longer needed hacks that enable spacebar scrolling in Firefox (issue 3498)
@timvandermeij timvandermeij merged commit 080ab20 into mozilla:master Apr 27, 2015
@timvandermeij
Copy link
Contributor

Thank you! Confirmed with Nightly that this is working and the patch has been merged almost a week ago upstream, so we should be good.

@Snuffleupagus Snuffleupagus deleted the issue-3498 branch April 27, 2015 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling using spacebar is broken in web viewer when using Firefox
3 participants