Don't map glyphs to certain problematic General Punctuation Unicode locations (bug 911034)

[Snuffleupagus]

Fixes the remaining missing characters in https://bugzilla.mozilla.org/show_bug.cgi?id=911034.

For reference, see http://www.unicode.org/charts/PDF/U2000.pdf (and also http://en.wikipedia.org/wiki/General_Punctuation_%28Unicode_block%29).

Note: With all the existing special cases for problematic character locations in adjustMapping, and given that we're most likely going to need to add even more in the future, I felt that readability was starting to become an issue. Hence the first patch, which extracts that code into a separate function.

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1677cb9d22ffd17/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9812883634b1b04/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/9812883634b1b04/output.txt

Total script time: 3.04 mins

• Font tests: FAILED
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/9812883634b1b04/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/1677cb9d22ffd17/output.txt

Total script time: 23.37 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[CodingFabian]

Thanks Jonas for your tireless work on those issues. I think the refactoring is fine, But as somebody who is not involved as you are, could you maybe add a comment line saying WHY these codes are "problematic", maybe linking the Wikipedia page?

[brendandahl]

/botio-windows test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/cddcfca4fa5fced/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/cddcfca4fa5fced/output.txt

Total script time: 18.63 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[brendandahl]

/botio makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6a9c6b55fa794d5/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/451f865fa5ef7a6/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/6a9c6b55fa794d5/output.txt

Total script time: 18.58 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/451f865fa5ef7a6/output.txt

Total script time: 22.68 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[timvandermeij]

Nice work! I like the separate function too.

[rohithns]

Which version of firefox can i expect this change be updated?

[timvandermeij]

I think Firefox 39 or 40 since that has to go through the Aurora and Beta branches before it gets to the Release branch.

[rohithns]

I there way i can test these changes using some build.

[Snuffleupagus]

I think Firefox 39 or 40 since that has to go through the Aurora and Beta branches before it gets to the Release branch.

The PDF.js updates land on mozilla-central first¹, hence Firefox 40 is the first version that will contain these changes.
Please note: This is under the assumption that we do an uplift during the current development cycle, and that these changes are not backed-out for causing regressions.

[1] Virtually all changes to Mozilla source code follows the pattern:
mozilla-central -> aurora -> beta -> release, with each period usually lasting six weeks. Please see the scheduled here: https://wiki.mozilla.org/RapidRelease/Calendar.

---

I there way i can test these changes using some build.

@rohithns The simplest way is to open your file(s) with the web viewer (by clicking on the Open file button on the toolbar): http://mozilla.github.io/pdf.js/web/viewer.html.