Enable OPS.setHScale in the SVG backend #5843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great! +1 for merging. |
Snuffleupagus
added a commit
that referenced
this pull request
Mar 16, 2015
Enable OPS.setHScale in the SVG backend
|
Seems fine; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The necessary code had already been implemented, but the operation had not yet been added to the
switchstatement. This resulted in a console message about an unimplemented operator. This patch makes http://kennemerlyceum.nl/attachments/article/4/Lessentabel%202014-2015.pdf render better since we now respect the horizontal text scale.To verify:
svgviewerexample without the patch applied and set it to load http://kennemerlyceum.nl/attachments/article/4/Lessentabel%202014-2015.pdf (download the file first).svgviewerexample, but now apply the patch. Notice subtle differences in spacing between the glyphs when switching between tabs.This patch is the result of an effort to find out what we are missing in the SVG backend. I have tested many different PDF files and observed the console output to determine essential missing operations. This was one of them. From what I have found shading/gradients/SMask are the biggest missing features. We will benefit from running the tests with the SVG backend to catch differences with the canvas rendering.