Don't map glyphs to Unicode "Dotted circle" combining mark (bug 1108301)

[Snuffleupagus]

It seems that 0x25CC is another bad spot for charCodes.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1108301.

Edit: Fixes one of the bugs in #5647.

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/cea6b0bfa0fa65e/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/cea6b0bfa0fa65e/output.txt

Total script time: 22.80 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2a1f5bb24ff3328/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/2a1f5bb24ff3328/output.txt

Total script time: 17.10 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[brendandahl]

Any idea why this character is special? BTW seems to be a windows only problem.

[Snuffleupagus]

Any idea why this character is special? BTW seems to be a windows only problem.

No, unfortunately not. I'm actually leaning towards closing the PR, since I have a hard time rationalizing why this patch is the "correct" solution.

[Snuffleupagus]

Actually, doing a code search against the Mozilla source gives interesting results: https://dxr.mozilla.org/mozilla-central/search?q=0x25CC&case=false.
I'm not pretending to understand anything about that code, or if it's even remotely relevant in this context, but there does appear to be some special handling of the 0x25CC charCode.

Edit: Looking at e.g. https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/hb-ot-shape.cc#236 or https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/hb-ot-shape-complex-sea.cc#275, I'm wondering if something like that would actually perfectly explain the issue that this patch attempts to fix.

[Snuffleupagus]

Rebased to fix merge conflicts in the test files, no functional code changes were made.

[brendandahl]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/de4b738597be3d4/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/e2f9b135217342e/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/e2f9b135217342e/output.txt

Total script time: 1.11 mins

• Lint: Passed
• Make references: FAILED

[brendandahl]

/botio-windows makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0329a166c00080c/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/0329a166c00080c/output.txt

Total script time: 17.68 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/de4b738597be3d4/output.txt

Total script time: 22.14 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed