Bug 1031612 - In PDF Viewer, the buggy XMP title "Untitled" overrides th... #5287
Conversation
| if (metadata && metadata.has('dc:title')) { | ||
| pdfTitle = metadata.get('dc:title'); | ||
| } | ||
|
|
There was a problem hiding this comment.
We still want metadata title be a preference
|
The idea at https://bugzilla.mozilla.org/show_bug.cgi?id=1031612#c4 is not implemented here. |
| @@ -1164,7 +1164,10 @@ var PDFView = { | |||
|
|
|||
| var pdfTitle; | |||
| if (metadata && metadata.has('dc:title')) { | |||
| pdfTitle = metadata.get('dc:title'); | |||
| var title = metadata.get('dc:title'); | |||
| if (title !== 'Untitled') { | |||
There was a problem hiding this comment.
You might want to make this check case insensitive, e.g. like this:
if (title.toLowerCase() !== 'untitled') {There was a problem hiding this comment.
if (title.toLowerCase() !== 'untitled') {
I would disagree with checking a lower case equivalent, but I would certainly expect to see a comment with explanation why we are doing the comparison.
… the document info title
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b3227f64a9bdebb/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b3227f64a9bdebb/output.txt Total script time: 1.04 mins Published
|
Bug 1031612 - In PDF Viewer, the buggy XMP title "Untitled" overrides th...
|
Thank you |
...e document info title
Reordered to make sure if info['Title'] exists, assign pdfTitle to it.