Skip to content

Add more cases to |mapSpecialUnicodeValues| to fix the rendering of various Symbol encoded brackets #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #2460.
Fixes #3599.
Fixes #4070.

Note: Also fixes a couple of pages in fips197.pdf.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0bf3c5d908e3d86/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7aa396bae05c82f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/000948c48ff18bb/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/7aa396bae05c82f/output.txt

Total script time: 2.83 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/7aa396bae05c82f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/000948c48ff18bb/output.txt

Total script time: 22.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/000948c48ff18bb/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

This is really awesome. Nice work!

/cc @yurydelendik for review

@yurydelendik
Copy link
Contributor

Nice. Can you create a map for those Unicode symbols? I'm afraid we will need to extend that in the future. I'm thinking of the following format:

var SpecialPUASymbols = {
  '63721': 0x00A9, // copyrightsans(0xF8E9) => copyright
  '63193': 0x00A9, // copyrightserif(0xF6D9) => copyright
  ...
}

and to speed up the SpecialPUASymbols[code] property look up, guard it with 0xF600 <= code && code <= 0xF8FF check.

@Snuffleupagus
Copy link
Collaborator Author

@yurydelendik Is this what you had in mind?

@yurydelendik
Copy link
Contributor

yes, this looks good

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/901bd8535441fee/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c4dd21461bac993/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/c4dd21461bac993/output.txt

Total script time: 20.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/c4dd21461bac993/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/901bd8535441fee/output.txt

Total script time: 22.53 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/901bd8535441fee/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ad3cdf37bfbc12f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/012a9d16a739605/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/012a9d16a739605/output.txt

Total script time: 20.28 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/ad3cdf37bfbc12f/output.txt

Total script time: 22.36 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

yurydelendik added a commit that referenced this pull request Sep 4, 2014
Add more cases to |mapSpecialUnicodeValues| to fix the rendering of various Symbol encoded brackets
@yurydelendik yurydelendik merged commit 2e83dc2 into mozilla:master Sep 4, 2014
@yurydelendik
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants