Fix CMap unit tests #5185
Merged
Fix CMap unit tests #5185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the binary CMaps were added, some of the relevant unit tests were not changed. This patch updates them, so that we actually test the current implementation. What's somewhat troubling here is that we currently have CMap unit tests that passes, *despite* not working as intended (the CMap files doesn't load).
|
/botio unittest |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/376f0b4cc9e4f38/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6a1baadc4f3441c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/376f0b4cc9e4f38/output.txt Total script time: 0.64 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/6a1baadc4f3441c/output.txt Total script time: 0.70 mins
|
It's a good idea. New PR will be okay for that. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the binary CMaps were added, some of the relevant unit tests were not changed. This patch updates them, so that we actually test the current implementation.
What's somewhat troubling here is that we currently have CMap unit tests that passes, despite not working as intended (the CMap files doesn't load).
Edit: When failing to
GETa CMap we shoulderror, see cmap.js#L390-L392 and cmap.js#L930-L932, but the condition isn't true, even when the CMap fails to load.I found a review comment for PR #4259 that was never addressed, which (in my testing) would fix the current situation where we fail to throw an error when the CMap is unavailable.
@yurydelendik If you think it's a good idea, I'd be happy to follow-up this PR with that fix!
In this PR I'm also removing the remaining references to cidmaps.js, which I missed in #5088.