Fix #4935 #5150
Fix #4935 #5150
Conversation
When loading the PDF from issue mozilla#4935, this change reduces peak RSS from ~2400 to ~300 MiB, and improves overall speed by ~81%, from 6336 ms to 1222 ms.
| map.isIdentity = true; | ||
| map.toUnicode = toUnicode; | ||
| return map; | ||
| return new IdentityToUnicodeMap(properties.firstChar, properties.lastChar); |
There was a problem hiding this comment.
According to Travis, this line is one character too long.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/78f65f472e04e3c/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ee557d009d8e54a/output.txt |
|
I fixed the too-long line. |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/78f65f472e04e3c/output.txt Total script time: 3.34 mins
Image differences available at: http://107.22.172.223:8877/78f65f472e04e3c/reftest-analyzer.html#web=eq.log |
|
The windows failure looks like an infrastructure fault. |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ee557d009d8e54a/output.txt Total script time: 22.57 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/86a8fcf2db74188/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/86a8fcf2db74188/output.txt Total script time: 0.76 mins Published
|
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a3e7f77e071e4cf/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/a3e7f77e071e4cf/output.txt Total script time: 2.86 mins
Image differences available at: http://107.22.172.223:8877/a3e7f77e071e4cf/reftest-analyzer.html#web=eq.log |
|
More Windows infra failures. |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/bbeb168a0a2510c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/bbeb168a0a2510c/output.txt Total script time: 19.84 mins
|
|
Awesome work. I can confirm that the loading time of the mentioned PDF went down from 8813 ms to 680 ms; a massive improvement! |
|
Looks good. Thank you. |
These changes greatly reduce the time and memory needed to render the document in #4935.